perf(mpsc): replace boxed receiver wakers - #182
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AtomicOptionBox<Waker>used by bounded and unbounded MPSC receivers with an internalAtomicWakerRationale
Every pending receiver poll currently clones a
Waker, allocates aBox, atomically exchanges its pointer, and drops the previous allocation. The new state machine stores the waker inline and skips cloning when the registered waker already targets the same task.The existing check-register-check sequence remains unchanged, so a wake that happens before registration is still observed through the second queue check. A wake that races with registration is completed by whichever side owns the inline waker slot.
The implementation remains private to Asyncband instead of adding an
atomic-waker-style dependency. On 64-bit targets this trades approximately 16 additional inline bytes per channel state for eliminating allocations on pending polls.Benchmarks
Local median results from repeated runs of
cargo bench -p benchmarks --bench benchmarks -- mpsc::reregister_pending_receiver mpsc::wake_pending_receiver:reregister_pending_receiverwake_pending_receiverValidation
cargo +nightly x lintcargo +nightly x checkcargo +1.86.0 x testcargo test --workspace --all-features