refactor(broadcast): remove overflow channel - #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
broadcast::overflowchannel and itsbroadcastCargo featureRationale
broadcast::overflowimplements the sliding/drop-oldest behavior deferred in #167. Its observable capacity, lag, resume-position, and eviction semantics need a clearer contract, and there is no concrete downstream requirement that justifies carrying the existing API into 0.7.Removing it now leaves room for the lossless bounded and unbounded broadcast APIs described in #167 without preserving an incompatible public path or error model. Shared waiter infrastructure remains in place because other primitives still use it.
Validation
cargo run -p x -- build --lockedcargo run -p x -- testcargo run -p x -- checkcargo run -p x -- lintcargo run -p x -- semver --release-version 0.7.0