Conversation
ClusterController.getNodeID() can return null when this node hasn't been assigned a node ID yet (e.g. during backup startup before the node-ID handshake completes). If a connection failure triggers a quorum vote in that window, vote() NPEs on getNodeID().toString(). Read the node ID once and treat a null value as "not yet identifiable as ourselves" instead of dereferencing it directly.
Contributor
|
Is this theoretical or did you actually see an NPE thrown here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClusterController.getNodeID()delegates toActiveMQServer.getNodeID(), which isnulluntil this node'sNodeManagerhas assigned/read a node ID.QuorumManager.vote()called.toString()on that value directly while filtering the local node out of the vote targets, so a connection failure that triggers a quorum vote before the node ID is set (e.g. very early in backup startup) throws aNullPointerException, surfacing asAMQ214002: Failed to execute failure listener.Test plan