GH-50517: [C++] RunEndEncodedBuilder does not merge consecutive NaN values - #51325
Open
andishgar wants to merge 1 commit into
Open
GH-50517: [C++] RunEndEncodedBuilder does not merge consecutive NaN values#51325andishgar wants to merge 1 commit into
andishgar wants to merge 1 commit into
Conversation
Member
|
What happens if you append different NaNs values? For example quiet_NaN vs. signaling_NaN. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
RunEndEncodedBuilderdoes not merge consecutive NaN values into a single run.What changes are included in this PR?
Enable merging consecutive NaN values into a single run.
Are these changes tested?
Yes, I added a unit test covering consecutive NaN values.
Are there any user-facing changes?
No.