Skip to content

MINOR: [Dev] Ask for generative AI disclosure in PR template - #51282

Open
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:minor-pr-template-ai
Open

MINOR: [Dev] Ask for generative AI disclosure in PR template#51282
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:minor-pr-template-ai

Conversation

@pitrou

@pitrou pitrou commented Sep 10, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Often, PR submitters who evidently used AI don't disclose their usage of AI. This adds a nudge to the PR template that they should be upfront about their usage of AI.

The downside is that it's one more question to answer when submitting a PR.

Are these changes tested?

No.

Are there any user-facing changes?

No.

@pitrou
pitrou marked this pull request as ready for review September 10, 2026 10:39
@pitrou

pitrou commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

@kou @raulcd @rok @HuaHuaY @wgtmac @thisisnic What do you think? Is this adding too much to the PR template?

@rok

rok commented Sep 10, 2026

Copy link
Copy Markdown
Member

How about adding a checkbox instead? (This was partially generated, idea was mine)
Written by:

  • Human
  • Human + AI
  • AI

Reviewed by:

  • Not reviewed
  • Human
  • AI
  • Human + AI

@thisisnic

Copy link
Copy Markdown
Member

I like the checkboxes, yeah!

@wgtmac

wgtmac commented Sep 10, 2026

Copy link
Copy Markdown
Member

I would expect that sometimes even the PR description is written by AI. We can tell the submitters to respect the PR template if not properly written.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I want to keep the "AI generation guidelines" link even if we use the suggested checkbox style.

We can tell the submitters to respect the PR template if not properly written.

It's out of scope of this PR but I want to automate it like our GH-XXX PR title check.

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Sep 10, 2026

* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
* [AI-generated Code Guidance](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code)

@HuaHuaY HuaHuaY Sep 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to delete this line? The guidance link is also provided in Was AI used for this PR? session.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to delete this line? The guidance link is also provided in Was AI used for this PR? session.

No preference from me. @kou What is your opinion?

@pitrou
pitrou force-pushed the minor-pr-template-ai branch from a64c5c2 to 812b6e5 Compare September 14, 2026 15:39
@pitrou
pitrou force-pushed the minor-pr-template-ai branch from 812b6e5 to b327fe6 Compare September 14, 2026 15:39
@pitrou

pitrou commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

How about adding a checkbox instead? (This was partially generated, idea was mine)

I suppose you gained a lot of productivity by generating this.

Since multiple boxes can be checked in a list, I removed the superfluous "Human + AI" choices.

@pitrou

pitrou commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

To all reviewers: feel free to comment on the updated version!

@rok

rok commented Sep 14, 2026

Copy link
Copy Markdown
Member

Looking at #51329 - should we expand this to issue templates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants