GH-50728: [C++] Remove call_traits::argument_count in favor of type_traits - #50729
Open
taepper wants to merge 2 commits into
Open
GH-50728: [C++] Remove call_traits::argument_count in favor of type_traits#50729taepper wants to merge 2 commits into
call_traits::argument_count in favor of type_traits#50729taepper wants to merge 2 commits into
Conversation
|
|
taepper
changed the title
call_traits::argument_count in favor of type_traitscall_traits::argument_count in favor of type_traits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As part of #50250 we slowly want to remove the custom metaprogramming helpers
What changes are included in this PR?
This removes
call_traits::argument_countin favor oftype_traits.We could also remove
ContinueFuture::ForSignaturebecausestd::invoke_resultalready checks the signature.Are these changes tested?
Yes.
Are there any user-facing changes?
No
call_traits::argument_count#50728