GH-50688: [CI] Force aws-sdk-cpp rebuild from brew to be compatible with aws-crt-cpp - #50712
GH-50688: [CI] Force aws-sdk-cpp rebuild from brew to be compatible with aws-crt-cpp#50712raulcd wants to merge 1 commit into
Conversation
…ible with aws-crt-cpp
|
|
|
This fixes the issue but requires a really long build time to the point of some jobs timing out, @kou should we just wait for brew to bump aws-sdk-cpp? |
|
Oh... Let's fix this in Homebrew instead of rebuilding it in our side. |
| # Workaround for https://github.com/grpc/grpc/issues/41755 | ||
| # Remove once the runner ships a newer Homebrew. | ||
| brew update |
There was a problem hiding this comment.
| brew update |
I've tried removing this outdated workaround for grpc build failure against protobuf v34 (that seems to be fixed in Homebrew/homebrew-core@552efca in March) so the runner should be on consistent grpc/protobuf and still without problematic aws-crt-cpp 0.43.x right now :)
Without brew update on my fork CI passes workflow Python and cpp
Perhaps that could be tried as a workaround until a future runner image is released with the mismatched bottles - which hopefully doesn't?
There was a problem hiding this comment.
sounds good to me, @tadeja do you want to submit a PR removing the brew update ?
There was a problem hiding this comment.
Ok, I'm submitting that then. Thanks for great analysis btw!
|
Can we find another workaround, such as pinning an earlier version? This seems to be ballooning CI run times. |
github-actions
Bot
added
awaiting changes
|
I am closing this PR as this was just to validate what the problem was. In my opinion if removing brew update fixes it, we can just work with the pinned versions from the GH runner. |
…lts (#50734) ### Rationale for this change Fix #50688, per analysis of #50712, `arrow-s3fs-test` segfaults because of incompatible aws-sdk-cpp and aws-crt-cpp bottles on current homebrew-core (Homebrew/homebrew-core#295531 bumped aws-crt-cpp to 0.43.0 without rebuilding the aws-sdk-cpp bottle). `brew update` was added in #49491 and is no longer needed (grpc/protobuf v34 got fixed in homebrew-core in March Homebrew/homebrew-core@ 552efcae and current runner ships that Homebrew snapshot including that). ### What changes are included in this PR? Remove brew update to avoid incompatible aws-sdk-cpp and aws-crt-cpp bottles. ### Are these changes tested? Yes, fork succeeded on Python and cpp workflows, now CI here succeeds too. ### Are there any user-facing changes? No. * GitHub Issue: #50688 Authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
4 participants
Rationale for this change
A brew bump to aws-crt-cpp seems to be causing segfaults due to aws-sdk-cpp not being rebuilt upstream.
What changes are included in this PR?
Force a rebuild for aws-sdk-cpp so it does not fail.
Are these changes tested?
Yes, previously failing CI jobs are now passing
Are there any user-facing changes?
No