GH-49837: [C++][Parquet] Avoid unbounded temporary std::vector in DELTA_(LENGTH_)BYTE_ARRAY decoder#49838
Open
pitrou wants to merge 1 commit intoapache:mainfrom
Open
GH-49837: [C++][Parquet] Avoid unbounded temporary std::vector in DELTA_(LENGTH_)BYTE_ARRAY decoder#49838pitrou wants to merge 1 commit intoapache:mainfrom
pitrou wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
Bot
added
Component: Parquet
Component: C++
awaiting review
pitrou
force-pushed
the
gh49837-delta-byte-array-std-vector
branch
from
714d562 to
39fc02f
Compare
Member
Author
|
@github-actions crossbow submit -g cpp |
|
Revision: 39fc02f Submitted crossbow builds: ursacomputing/crossbow @ actions-2ca183efe9
|
…in DELTA_(LENGTH_)BYTE_ARRAY decoder
pitrou
force-pushed
the
gh49837-delta-byte-array-std-vector
branch
from
39fc02f to
14d3f53
Compare
Member
Author
|
@github-actions crossbow submit -g cpp |
|
Revision: 14d3f53 Submitted crossbow builds: ursacomputing/crossbow @ actions-3c858e4ad0
|
pitrou
commented
Apr 22, 2026
Comment on lines
+96
to
+98
| #ifndef ARROW_ENABLE_THREADING | ||
| GTEST_SKIP() << "Test requires threading support"; | ||
| #endif |
Member
Author
There was a problem hiding this comment.
This is a quick fix for an unrelated CI regression.
github-actions
Bot
added
awaiting committer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
DeltaLengthByteArrayDecoder::DecodeArrowandDeltaByteArrayDecoder::DecodeArrowboth allocate a temporarystd::vectorfor the entire range of decoded values.This generates out-of-memory failures in the Parquet encoding fuzzer as this unbounded allocation bypasses the custom fuzzing memory pool.
This issue was found by OSS-Fuzz: https://oss-fuzz.com/testcase-detail/6634166832922624
What changes are included in this PR?
Use the given MemoryPool to allocate a temporary buffer, so that potential memory limits are applied.
Are these changes tested?
Yes, using existing tests.
Are there any user-facing changes?
No.