Skip to content

GH-49816: [C++][FlightRPC] Only Run ODBC tests on ODBC CI#49819

Open
alinaliBQ wants to merge 1 commit intoapache:mainfrom
Bit-Quill:gh-49816-only-run-odbc-tests
Open

GH-49816: [C++][FlightRPC] Only Run ODBC tests on ODBC CI#49819
alinaliBQ wants to merge 1 commit intoapache:mainfrom
Bit-Quill:gh-49816-only-run-odbc-tests

Conversation

@alinaliBQ
Copy link
Copy Markdown
Collaborator

@alinaliBQ alinaliBQ commented Apr 20, 2026

Rationale for this change

GH-49816

Only run ODBC tests on ODBC CI for easier maintenance.

What changes are included in this PR?

  • CIs that have ODBC enabled (ARROW_FLIGHT_SQL_ODBC: ON) will only run ODBC tests arrow-flight-sql-odbc-test and arrow-odbc-spi-impl-test.
  • Only ODBC CIs are affected by this change

Are these changes tested?

  • Yes, in CI

Are there any user-facing changes?

N/A

* Only Run ODBC-related tests on CI
@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #49816 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions Bot added the awaiting review Awaiting review label Apr 20, 2026
@alinaliBQ alinaliBQ added the CI: Extra: C++ Run extra C++ CI label Apr 21, 2026
@alinaliBQ alinaliBQ marked this pull request as ready for review April 21, 2026 21:36
@alinaliBQ
Copy link
Copy Markdown
Collaborator Author

@lidavidm PR is ready for review

Copy link
Copy Markdown
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add an include_tests, set by env var, to go with exclude_tests, then adjust the CI config to set this via env var? That way we aren't adjusting the test script (which may be used locally as well). On the other hand it seems exclude_tests etc. is also basically only meant for CI, so I'll defer to someone who is more familiar with the CI setup.

@alinaliBQ
Copy link
Copy Markdown
Collaborator Author

Yea you have a point there, I raised issue #49842 (unassigned) to use an environment variable to adjust exclude/include tests. Since the approach in #49842 is preferred, I’m okay with leaving this PR open or closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes Awaiting changes CI: Extra: C++ Run extra C++ CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants