perf: avoid re-allocation if buffer is not shared - #10438
Open
Rich-T-kid wants to merge 1 commit into
Open
Conversation
Rich-T-kid
commented
Jul 26, 2026
Comment on lines
+599
to
+601
| for i in end..len { | ||
| bit_util::unset_bit(mutable_buffer.as_slice_mut(), i); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Im sure there are faster ways to do this. I looked up a few ways to do this and im not too familar with bit operations so I left is as a basic loop for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Buffer.into_mutableto reuse the allocation if possible intake_n_true#10251.Rationale for this change
If a boolean buffer is not shared we should re-use its allocation instead of building a new builder from scratch.
What changes are included in this PR?
match on
into_mutable, in the error case the old path is taken. If the buffer can be re-used we use it directly.Are these changes tested?
yes, existing test cover this behavior
Are there any user-facing changes?
no