Make the objenesis import mandatory in proxy-impl - #913
Open
holgerfriedrich wants to merge 1 commit into
Open
holgerfriedrich wants to merge 1 commit into
holgerfriedrich wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #414
ProxySubclassGeneratorreferences org.objenesis directly, so the class cannot be loaded without it.AsmProxyManager.isProxyClass()loads that class for every proxy, including interface-only ones, so with the import declared optional a bundle resolves and then fails withNoClassDefFoundError: org/objenesis/Objenesison the first proxy.If you want to keep it strictly optional, then we would need to restructure and use Objenesis only for those cases where it is required.
Discovered when I had to add a new dep to the feature in apache/karaf#2214 to fix tests - though feature resolution was fine before.