feat(openid-connect): add stateless session revocation options#13651
Open
Hockenba wants to merge 4 commits into
Open
feat(openid-connect): add stateless session revocation options#13651Hockenba wants to merge 4 commits into
Hockenba wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.redis.mode(storage|revocation) andsession.revocation_fail_mode(open|closed) to the openid-connect plugin schema.lua-resty-sessionas-is; revocation is auto-loaded by the library whenstorageiscookieand Redis is configured for revocation (no APISIX-siderevocation=truetranslation).t/plugin/openid-connect-revocation.tcovering schema validation, config passthrough, and fail-open/fail-closed runtime behavior.Dependency
This plugin change depends on
lua-resty-sessioncookie-session revocation support (Redis denylist onopen()/destroy()). A companion change PR is required inlua-resty-session before this can land in APISIX.
Test plan
prove t/plugin/openid-connect-revocation.t(withlua-resty-sessionrevocation support installed)prove t/plugin/openid-connect*.tsession.redis.modeisrevocationrevocation_fail_mode=openallows requests when Redis is unreachablerevocation_fail_mode=closedrejects sessions when Redis is unreachable