feat(openid-connect): support PAR and DPoP client options#13649
Open
kevinlzw wants to merge 1 commit into
Open
feat(openid-connect): support PAR and DPoP client options#13649kevinlzw wants to merge 1 commit into
kevinlzw wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I maintain
lua-resty-openidc, and the latestlua-resty-openidc1.9.0 release added client-side PAR and DPoP support. This PR bumps APISIX to that release and exposes the new client-side OAuth/OIDC options through theopenid-connectPlugin.This PR adds nested APISIX Plugin configuration for:
The APISIX Plugin keeps user-facing PAR and DPoP options grouped under
paranddpop, then maps them to the flat option names expected bylua-resty-openidcbefore invoking the library. It also encryptsdpop.private_keyin etcd and documents the new options in English and Chinese.Related to #11219. This PR covers the
openid-connectPlugin acting as an OAuth/OIDC client/Relying Party. It does not implement APISIX resource-server-side DPoP proof validation.Backward compatibility
This change is backward compatible for existing
openid-connectPlugin configurations:par,dpop, or client assertion algorithm attributes.dpop.private_keyencryption only affects the new DPoP private-key field.Which issue(s) this PR fixes:
Related to #11219
Checklist
Tests
git -C apisix diff --checkapisix/plugins/openid-connect.luaprove -I../test-nginx/lib -I./ -r -s t/plugin/openid-connect.tFiles=1, Tests=175, Result: PASSmake lintwas run in a Docker temporary copy of the Windows checkout after normalizing CRLF line endings and installingluacheckin the temporary container:luacheck -q apisix t/lib:0 warnings / 0 errors in 376 fileslj-relengstill fails on existing repository-wide line-length/style findings, including pre-existingopenid-connect.lualong lines not introduced by this PR.