fix: default listenerPortMatchMode to off in apisix and ingress-controller charts#976
Open
AlinsRan wants to merge 2 commits into
Open
fix: default listenerPortMatchMode to off in apisix and ingress-controller charts#976AlinsRan wants to merge 2 commits into
AlinsRan wants to merge 2 commits into
Conversation
AlinsRan
changed the title
added 2 commits
June 10, 2026 10:43
The auto mode (apisix-ingress-controller#2703, shipped in 2.1.0) injects a server_port route var derived from the Gateway listener port (e.g. 80/443), but APISIX server_port reflects the data-plane listening port (e.g. 9080/9443), so routes 404 after upgrade. Default to off so port-var injection is opt-in.
… off Mirror the subchart default change in the umbrella apisix chart so bundled deployments also default port-var injection to off.
AlinsRan
force-pushed
the
fix/listener-port-match-default-off
branch
from
ab45d84 to
1cdc185
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Changes the default of
listenerPortMatchModefromautotoofffor both theapisix-ingress-controllerchart and the umbrellaapisixchart.Why
automode (introduced in apache/apisix-ingress-controller#2703, shipped in 2.1.0) injects aserver_portroute var into any route matching multiple listener ports. The injected value is the Gateway listener port (e.g.80/443), but the APISIXserver_portvariable reflects the port the data plane actually listens on (e.g.9080/9443— the Service maps80/443 → 9080/9443). The two never match, so every multi-listener route returns404after upgrading.See apache/apisix-ingress-controller#2782 for the full analysis.
Changes
charts/apisix-ingress-controllervalues.yaml:config.listenerPortMatchModenow defaults to"off"(with an explanatory comment).templates/configmap.yaml: template default updated tooff.README.md: regenerated default value.Chart.yaml: version1.2.0→1.2.1.charts/apisix(umbrella)values.yaml: pinsingress-controller.config.listenerPortMatchMode: "off"so bundled deployments inherit the safe default.Chart.yaml: version2.14.1→2.14.2.Rendered output verified (
listener_port_match_mode: off) andhelm lintpasses. Users who run APISIX withnode_listenaligned to their Gateway listener ports can still opt back in viaconfig.listenerPortMatchMode: auto/explicit.