Repository navigation
Avoid creating a new process just to set goal state in MAC - #6582
Merged
Merged
Conversation
dlmarion
approved these changes
Oct 8, 2026
dlmarion
left a comment
dlmarion
left a comment
Contributor
There was a problem hiding this comment.
To future-proof somewhat, you could also move the line of code in SetGoalState.main() into a public static void method that accepts a ServerContext and just call that method from here.
Member
Author
Good idea. Refactored into a helper method in 65f0dd8 |
ddanielr
reviewed
Oct 9, 2026
ddanielr
approved these changes
Oct 9, 2026
dlmarion
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAC start-up launched a separate JVM just to run
SetGoalStateand waited for it before starting the manager. This PR speeds things up by doing that ZK write directly from the existing test process using the server context already available.From some rough timing prints, the replaced goal state step went from ~1.6s -> ~0.25-0.7 seconds. Most ITs use this path so the time savings really add up over the coarse of a full build.