Skip to content

Fix Scan Server Status Icon colors in 4.0.0 Monitor #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amemeda wants to merge 11 commits into
base: main
Choose a base branch
from
+22 −1
Open

Fix Scan Server Status Icon colors in 4.0.0 Monitor #6581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0358bfe
Add new logic to determine server icon status
Amemeda Oct 7, 2026
292b08b
Add STATUS.OK to another condition
Amemeda Oct 7, 2026
ed4ba69
Moving scan server icon status logic to function.js
Amemeda Oct 9, 2026
0043006
Restore navbar.js
Amemeda Oct 9, 2026
cc4df5a
Restore navbar.js
Amemeda Oct 9, 2026
f702889
Add new method to return server counts for component, for use in func…
Amemeda Oct 9, 2026
ae7ac08
Add responding and total servers to getComponentStatus
Amemeda Oct 9, 2026
1580a42
Remove test code from navbar.js
Amemeda Oct 9, 2026
f9d2bc1
Send correct parameter into getServerCounts
Amemeda Oct 9, 2026
8d0aa40
Fix spacing
Amemeda Oct 9, 2026
92d667a
Fix more spacing
Amemeda Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,11 +575,24 @@ function getStoredStatusData() {
}

function getComponentStatus(statusData, componentType) {
const status = statusData.componentStatuses[componentType];

if (componentType === 'SCAN_SERVER'){
const respondingServers = getServerCounts(status).at(0);
const totalServers = getServerCounts(status).at(1);
if (respondingServers === totalServers) {
return 'OK';
} else if (respondingServers === 0 && totalServers > 0) {
return 'ERROR';
} else if (respondingServers > 0 && respondingServers < totalServers){
return 'WARN'
}
}

Comment on lines 577 to +591

@Amemeda Amemeda Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created and implemented new function getServerCounts to get the current component's responding servers and total servers counts. I believe something like this is needed in order to properly set the expected status of only Scan Servers

if (!statusData || !statusData.componentStatuses) {
return 'ERROR';
}

var status = statusData.componentStatuses[componentType];
if (!status || !status.hasServers) {
return 'ERROR';
}
Expand Down
8 changes: 8 additions & 0 deletions server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/navbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,14 @@ function updateServerCount(elementId, status) {
$element.text(`${responding}/${total}`);
}

function getServerCounts(component)
{
const total = Number(component.serverCount);
const problem = Number(component.problemServerCount || 0);
const responding = Math.max(0, total - problem);
return [responding, total];
}

/**
* Updates the notifications of the servers dropdown notification as well as the individual server notifications.
* @param {JSON} statusData object containing the status info for the servers
Expand Down