Skip to content

Use private Thrift members#6430

Open
Amemeda wants to merge 10 commits into
apache:mainfrom
Amemeda:thrift-private-members
Open

Use private Thrift members#6430
Amemeda wants to merge 10 commits into
apache:mainfrom
Amemeda:thrift-private-members

Conversation

@Amemeda

@Amemeda Amemeda commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Updated generate-thrift.sh script to use private members
  • Lots of java files automatically updated the public thrift fields to private after script change
  • Manually updated 53 java files to use getters and setters for the updated private thrift members

@Amemeda Amemeda marked this pull request as draft June 16, 2026 18:56
@Amemeda Amemeda changed the title Update generate-thrift.sh script to use private members Use private Thrift members Jun 16, 2026
This was referenced Jun 16, 2026
Closed
Closed
@ctubbsii

ctubbsii commented Jun 16, 2026

Copy link
Copy Markdown
Member

This will fix #3404

@ctubbsii ctubbsii added this to the 4.0.0 milestone Jun 16, 2026
@ctubbsii

ctubbsii commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@Amemeda GitHub won't let me link to the original issue, #3404 . If you add a comment in the body of one of your commits that says Fixes #3404, it might let us link to it. EDIT: I got it linked, but it's still a good idea to have that line in the commit message that we end up with in the end.

@ctubbsii ctubbsii linked an issue Jun 16, 2026 that may be closed by this pull request
Generate thrift with private members #3404
Open
DomGarguilo
DomGarguilo requested changes Jun 17, 2026
View reviewed changes
Comment thread core/src/main/java/org/apache/accumulo/core/data/Column.java Outdated
Comment thread core/src/main/java/org/apache/accumulo/core/iteratorsImpl/IteratorConfigUtil.java Outdated
Comment thread core/src/main/java/org/apache/accumulo/core/iteratorsImpl/IteratorConfigUtil.java Outdated
Comment thread server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java Outdated
Amemeda and others added 3 commits June 17, 2026 16:03
@Amemeda
Correcting use of wrong get method
89c2aed
@Amemeda @DomGarguilo
Update server/tserver/src/main/java/org/apache/accumulo/tserver/Table…
93df344 
…tStatsKeeper.java


Correcting use of wrong get and set method

Co-authored-by: Dom G. <domgarguilo@apache.org>
@Amemeda @DomGarguilo
Update core/src/main/java/org/apache/accumulo/core/data/Column.java
47ae4dd 
Correcting to still use toBytes()

Co-authored-by: Dom G. <domgarguilo@apache.org>
@Amemeda Amemeda marked this pull request as ready for review June 17, 2026 21:11
DomGarguilo
DomGarguilo approved these changes Jun 18, 2026
View reviewed changes

@DomGarguilo DomGarguilo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM. Going to kick off a full build since this touches so many files.

@DomGarguilo DomGarguilo requested a review from ctubbsii June 18, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DomGarguilo DomGarguilo DomGarguilo approved these changes

@ctubbsii ctubbsii Awaiting requested review from ctubbsii

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

Generate thrift with private members

3 participants

@Amemeda @ctubbsii @DomGarguilo