Repository navigation
Fix props file newline potential bugs - #317
Merged
Merged
Conversation
ctubbsii
approved these changes
Sep 17, 2026
ctubbsii
left a comment
Member
There was a problem hiding this comment.
Your echos in a block with a consolidated file append redirect was good, but I think this heredoc version I added is a little more readable... don't have to deal with quotes as much, and no redundant echo commands.
Member
Author
Yea your version is better. Thanks for the improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing some testing, I added a property to
accumulo.propertiesvia anecho ... >>command, assuming there was a newline at the end of the file. There wasn't, so it appended the property to the value of the final line, which messed things up.This PR adds a newline to the props file. I also did some digging and found that the encryption plugin relied on that newline too. Its first property was getting tacked onto the end of the last line, so
instance.crypto.opts.key.urinever actually got set. I changed that part of the plugin to write its props as a block with a blank line and a comment before it, so it doesn't rely on the newline anymore (even though it is there now).While I was in there, I also noticed the plugin had the accumulo-core jar version hardcoded to 2.x, so I made that version agnostic.