Repository navigation
fix(async): preserve caller context for message requests - #431
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #430. The main and beta async message services composed
prepareAsync()withthenComposeAsync()at each of their three request call sites. With the current completed request-preparation future, that schedulesHttpClient.executeAsync()onForkJoinPool.commonPool()and drops caller thread-local context before transport instrumentation observes the request.Use non-async
thenCompose()for create, streaming create, and count-tokens requests in both services. This avoids the implicit common-pool hop and preserves the preparation/completion thread's context;streamHandlerExecutorremains dedicated to stream callbacks.Validation
HttpClientand aThreadLocal; they cover all three methods in both main and beta services.afb2c556f90c2da15f5ebd63ee7be604cf59edaf, the two streaming regressions failed before the fix (context wasnull) and all six tests passed after it.main(c0f5915f7dd34cef8d5f03fdc8cdd4f93933c47e) succeeded. A post-rebase focused Gradle run timed out after 600 seconds during:anthropic-java-core:compileTestKotlin; no test result was produced by that attempt. No provider API or external test endpoint was used.