Repository navigation
fix: Fix scalar variables not applying after re-selecting a part colored by a vector component - #162
Merged
Merged
Conversation
LKasianAnsys
changed the base branch from
main
to
feat/3.5c-server-created-lut
October 7, 2026 17:50
LKasianAnsys
force-pushed
the
feat/3.5c-server-created-lut
branch
from
October 7, 2026 20:33
af3d4d1 to
1b26164
Compare
LKasianAnsys
force-pushed
the
feat/3.5d-fix-color-by-vector-part
branch
from
October 7, 2026 20:43
9345a46 to
baabf94
Compare
LKasianAnsys
force-pushed
the
feat/3.5c-server-created-lut
branch
from
October 7, 2026 21:33
1b26164 to
0c9b735
Compare
LKasianAnsys
force-pushed
the
feat/3.5d-fix-color-by-vector-part
branch
from
October 7, 2026 21:35
79460f0 to
37fb9ea
Compare
LKasianAnsys
marked this pull request as ready for review
October 7, 2026 22:39
LKasianAnsys
force-pushed
the
feat/3.5c-server-created-lut
branch
from
October 13, 2026 16:39
0c9b735 to
0189582
Compare
LKasianAnsys
force-pushed
the
feat/3.5d-fix-color-by-vector-part
branch
from
October 13, 2026 16:43
bcfa019 to
12a0c39
Compare
LKasianAnsys
force-pushed
the
feat/3.5d-fix-color-by-vector-part
branch
from
October 14, 2026 20:40
a6db32a to
77a32cd
Compare
ansBAkula
approved these changes
Oct 15, 2026
ansBAkula
left a comment
Collaborator
There was a problem hiding this comment.
Tested and works. One small improvement (non functional): we could probably avoid showing the "Component" label and the associated dropdown showing up as "Magnitude" for scalar fields.
Collaborator
Author
|
@ansBAkula Yes agreed, nice suggestion. I've added it as an issue (#156) under the UI work feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Addresses #23
Context
User story 3.5 (#23) of the remote rendering epic sees the variable ownership and color lookup table move from the client to the server. This PR fixes a pre-existing bug (described in the summary below) when coloring by a component of a vector or tensor variable.
To test:
Copilot summary
This pull request addresses an issue where scalar variables were not being correctly applied after re-selecting a part that was previously colored by a vector component. The changes ensure that, upon re-selection, the correct variable component is chosen, defaulting to the first available option when necessary. The logic for resolving the displayed component was refactored and better tested, and new tests were added to verify the fix.
Bug fix:
Refactoring and improved logic:
#resolveNodeComponentIdinAggregateVariableInfo, improving clarity and maintainability.Testing improvements: