Skip to content

fix(app): back off event stream reconnects after repeated failures #48015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CannonRS wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −1
Open

fix(app): back off event stream reconnects after repeated failures #48015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/app/src/context/server-sdk.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ function createServerSdkContextBase(server: ServerConnection.Any, scope: ServerS
started = true
const active = ++generation
const previous = run
let consecutiveErrors = 0
const current = (async () => {
if (previous) await previous
// oxlint-disable-next-line no-unmodified-loop-condition -- `started` is set to false by stop() which also aborts; both flags are checked to allow graceful exit
Expand All @@ -279,6 +280,7 @@ function createServerSdkContextBase(server: ServerConnection.Any, scope: ServerS
: eventApi.event.subscribe({ signal: attempt.signal })
let yielded = Date.now()
for await (const event of events) {
consecutiveErrors = 0
streamErrorLogged = false
const legacy = "payload" in event
if (legacy && event.payload.type === "sync") continue
Expand All @@ -291,6 +293,7 @@ function createServerSdkContextBase(server: ServerConnection.Any, scope: ServerS
await wait(0)
}
} catch (error) {
consecutiveErrors++
if (!isStreamClosed(error, attempt?.signal) && !streamErrorLogged) {
streamErrorLogged = true
console.error("[global-sdk] event stream failed", {
Expand All @@ -305,7 +308,8 @@ function createServerSdkContextBase(server: ServerConnection.Any, scope: ServerS
}

if (abort.signal.aborted || !started || generation !== active) return
await wait(RECONNECT_DELAY_MS)
const backoff = Math.min(5000, RECONNECT_DELAY_MS * Math.pow(1.5, Math.min(consecutiveErrors, 8)))
await wait(backoff)
}
})().finally(() => {
if (run !== current) return
Expand Down
Loading