fix(session-ui): truncate long reasoning headings instead of overflowing - #48008
Open
CannonRS wants to merge 1 commit into
Open
fix(session-ui): truncate long reasoning headings instead of overflowing#48008CannonRS wants to merge 1 commit into
CannonRS wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48007
Type of change
What does this PR do?
Long reasoning headings in the
session-turn-thinkingrow overflow the timelineto the right: the heading is a flex child with
min-width: 0but no overflowhandling, and
TextRevealrenders withwhite-space: nowrap.The change clips the heading to the available row width:
session-turn.css:.session-turn-thinking-headinggainsoverflow: hidden; white-space: nowrap; text-overflow: ellipsis.session-turn.tsx/message-timeline.tsx: both thinking rows passtruncateto
TextReveal, which the component already supports (data-truncatesets thetrack width to
100%and applies ellipsis). No new component surface is added.How did you verify your code works?
TextReveal.truncatealready exists upstream (props.truncate+data-truncateCSS), so the change is purely wiring + one CSS rule.
packages/session-uiin the fork run is green; the worktreetypecheck is currently blocked by an environment-level
vite/client.d.tsparse error from the worktree
bun install(unrelated to this change — thesame files typecheck in the fork where the identical code is committed).
git diff --checkclean; diff is +5/-1 across three files.Screenshots / recordings
N/A — visual-only clipping fix, no behavioural change outside the clipped heading.
A recording can be added on request.
Fork
Checklist