feat: add URL-prefix support to OpenCode Web (even behind prefix-stripping reverse proxies) - #47977
Draft
fromelicks wants to merge 34 commits into
Draft
feat: add URL-prefix support to OpenCode Web (even behind prefix-stripping reverse proxies)#47977fromelicks wants to merge 34 commits into
fromelicks wants to merge 34 commits into
Conversation
…enzi/opencode into feat/base-path-support
# Conflicts: # packages/opencode/src/server/routes/instance/httpapi/server.ts # packages/opencode/src/server/server.ts
…enzi/opencode into feat/base-path-support
# Conflicts: # packages/opencode/src/server/routes/instance/httpapi/server.ts
# Conflicts: # packages/app/src/env.d.ts
…t/base-path-support
…t/base-path-support
The v1 generated client used new URL(descriptor.path, options.baseUrl) which drops the path component of baseUrl when descriptor.path is absolute. This caused all v1 client API requests to miss the --base-path prefix, breaking reverse proxy deployments. Fix: use string concatenation (baseUrl + path) instead of new URL(path, baseUrl), matching the v2 SDK approach. Also fixes server-protocol.ts which had the same new URL() pattern. Added test: 'preserves base path in request URLs'
Merge anomalyco#28326 and fabiovincenzi#1, retaining their commit history. Exclude the unrelated models.json snapshot.
Port anomalyco#47442 onto dev, including generated and vendored clients, raw CLI requests, and terminal URLs. Support proxies that remove the public URL prefix and complete assets, PWA, deep-link, tab, and session-path handling. Validate client generation and archive reproducibility, server/client/app regressions, real HTTP listeners and PTYs, package typechecks, standalone builds, and browser navigation through a reverse proxy.
github-actions
Bot
added
needs:compliance
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found that PR #47977 (the current PR) is a merge of three existing PRs. The PR description itself explicitly mentions it closes:
The search results show that PR #47442 and PR #28326 are directly related and are mentioned as being merged into the current PR #47977. These are not duplicates in the traditional sense—the current PR #47977 is intentionally consolidating these related PRs together, as stated in the description: "This a merge of three PRs." No other open duplicate PRs found that haven't already been acknowledged and merged into PR #47977. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
fromelicks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #7624, closes #28326, closes fabiovincenzi#1, closes #46498, closes #47442.
This a merge of three PRs: #28326, fabiovincenzi#1 and #47442. I made it for myself.
Type of change
What does this PR do?
Adds URL-prefix support to OpenCode Web behind reverse proxies that preserve or strip the prefix. Keeps assets, API/SSE requests, terminal WebSockets, and session/tab navigation under the configured path, including deep-link reloads.
How did you verify your code works?
I've ran all local tests. I compiled it to an executable
opencodeand run it behind reverse proxy with prefix.Checklist
If you do not follow this template your PR will be automatically rejected.