fix(sdk): handle SSE cancellation rejection - #47966
Open
arkaydeus wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #47963
Type of change
What does this PR do?
The SSE abort handler called
reader.cancel()without observing its promise, so Bun could report an unhandledAbortErrorafter the body stream had already errored.This observes the cancellation rejection in both generated SDK clients and patches the v2 generation step so regeneration preserves the fix.
How did you verify your code works?
./script/generate.tsto regenerate the SDK and confirm the patch is preserved.bun testandbun typecheckfrompackages/sdk/js.reader.read()is pending. The test fails with the previous implementation because Bun sees the unhandled rejection.Screenshots / recordings
Not applicable; this is an SDK-only change.
Checklist