Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/opencode/src/permission/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { InstanceState } from "@/effect/instance-state"
import { Wildcard } from "@opencode-ai/core/util/wildcard"
import { Deferred, Effect, Layer, Context } from "effect"
import os from "os"
import { FSUtil } from "@opencode-ai/core/fs-util"
import { PermissionV1 } from "@opencode-ai/core/v1/permission"
import { EventV2Bridge } from "@/event-v2-bridge"

Expand Down Expand Up @@ -175,11 +176,16 @@ const layer = Layer.effect(
}),
)

function expand(pattern: string): string {
if (pattern.startsWith("~/")) return os.homedir() + pattern.slice(1)
if (pattern === "~") return os.homedir()
if (pattern.startsWith("$HOME/")) return os.homedir() + pattern.slice(5)
if (pattern.startsWith("$HOME")) return os.homedir() + pattern.slice(5)
export function expand(pattern: string): string {
if (pattern.startsWith("~/")) pattern = os.homedir() + pattern.slice(1)
if (pattern === "~") pattern = os.homedir()
if (pattern.startsWith("$HOME/")) pattern = os.homedir() + pattern.slice(5)
if (pattern.startsWith("$HOME")) pattern = os.homedir() + pattern.slice(5)
// On Windows, normalise absolute path patterns through the same realpath pass
// the runtime applies to ask targets. Otherwise whitelist entries written as
// symlinked/junction paths (e.g. ~/.claude resolving to ~/.codex) never match
// the canonicalised request and every external read prompts anyway.
if (process.platform === "win32" && /^[A-Za-z]:[\\/]/.test(pattern)) return FSUtil.normalizePathPattern(pattern)
return pattern
}

Expand Down
27 changes: 27 additions & 0 deletions packages/opencode/test/permission/expand.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { describe, expect, test } from "bun:test"
import { Permission } from "../../src/permission"

describe("Permission.expand", () => {
test("keeps non-path permission patterns untouched", () => {
expect(Permission.expand("ls")).toBe("ls")
expect(Permission.expand("*.env")).toBe("*.env")
expect(Permission.expand("src/index.ts")).toBe("src/index.ts")
})

test("expands tilde and $HOME to the home directory", () => {
const home = process.env.HOME ?? process.env.USERPROFILE ?? ""
expect(Permission.expand("~/foo").startsWith(home)).toBe(true)
expect(Permission.expand("$HOME/foo").startsWith(home)).toBe(true)
expect(Permission.expand("~/foo")).toContain("foo")
})

if (process.platform === "win32") {
test("normalises a windows drive whitelist path via realpath (junction-resolving)", () => {
const resolved = Permission.expand("C:/Users/test/.claude/skills/skill/*")
// Either the real path resolves (junction) or it stays as given — the drive
// prefix and trailing wildcard must survive.
expect(resolved).toMatch(/^[A-Za-z]:[\\/]/)
expect(resolved.replaceAll("\\", "/").endsWith("*")).toBe(true)
})
}
})
12 changes: 9 additions & 3 deletions packages/opencode/test/permission/next.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import os from "os"
import { Cause, Deferred, Effect, Exit, Fiber, Layer } from "effect"
import { EventV2Bridge } from "../../src/event-v2-bridge"
import { CrossSpawnSpawner } from "@opencode-ai/core/cross-spawn-spawner"
import { FSUtil } from "@opencode-ai/core/fs-util"
import { Permission } from "../../src/permission"
import { InstanceBootstrap } from "../../src/project/bootstrap"
import { InstanceStore } from "../../src/project/instance-store"
Expand Down Expand Up @@ -110,17 +111,22 @@ test("fromConfig - empty object", () => {

test("fromConfig - expands tilde to home directory", () => {
const result = Permission.fromConfig({ external_directory: { "~/projects/*": "allow" } })
expect(result).toEqual([{ permission: "external_directory", pattern: `${os.homedir()}/projects/*`, action: "allow" }])
const expected =
process.platform === "win32" ? FSUtil.normalizePathPattern(`${os.homedir()}/projects/*`) : `${os.homedir()}/projects/*`
expect(result).toEqual([{ permission: "external_directory", pattern: expected, action: "allow" }])
})

test("fromConfig - expands $HOME to home directory", () => {
const result = Permission.fromConfig({ external_directory: { "$HOME/projects/*": "allow" } })
expect(result).toEqual([{ permission: "external_directory", pattern: `${os.homedir()}/projects/*`, action: "allow" }])
const expected =
process.platform === "win32" ? FSUtil.normalizePathPattern(`${os.homedir()}/projects/*`) : `${os.homedir()}/projects/*`
expect(result).toEqual([{ permission: "external_directory", pattern: expected, action: "allow" }])
})

test("fromConfig - expands $HOME without trailing slash", () => {
const result = Permission.fromConfig({ external_directory: { $HOME: "allow" } })
expect(result).toEqual([{ permission: "external_directory", pattern: os.homedir(), action: "allow" }])
const expected = process.platform === "win32" ? FSUtil.normalizePath(`${os.homedir()}`) : os.homedir()
expect(result).toEqual([{ permission: "external_directory", pattern: expected, action: "allow" }])
})

test("fromConfig - does not expand tilde in middle of path", () => {
Expand Down
Loading