Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ test("keeps the file-browser sidebar mounted when switching file tabs", async ({
expect(await readProbe(page)).toBe(PROBE)
await expect.poll(() => viewport.evaluate((element) => element.scrollTop)).toBe(scrolled)
})
test.afterEach(async ({ page }, info) => {
if (info.status === "passed") await page.screenshot({ path: info.outputPath("review-files-extension.png") })
})

type Probed = HTMLElement & { __e2eProbe?: string }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ test("uses side placement by default and supports the terminal across the bottom
await expectSessionReady(page, { server, sessionID, title })
await expect(page.locator("#review-panel")).toBeVisible()
await expectTree(page, 2_773, "action.yml")
await expect(page.locator("#session-side-panel-review-tab")).toHaveText("Files Changed 2740")
await expect(page.locator("#review-panel").getByRole("tab", { name: "Files Changed 2740", exact: true })).toBeVisible()
await page.keyboard.press("Control+Backquote")
await expect(page.locator("#terminal-panel")).toBeVisible()
await expectTree(page, 2_773, "action.yml")
Expand Down
1 change: 1 addition & 0 deletions packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
"@kobalte/core": "catalog:",
"@opencode/client": "workspace:*",
"@opencode/plugin": "workspace:*",
"@opencode/plugin-review-desktop": "workspace:*",
"@opencode/schema": "workspace:*",
"@opencode/session-ui": "workspace:*",
"@opencode/ui": "workspace:*",
Expand Down
3 changes: 2 additions & 1 deletion packages/app/src/extensions/provider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import { base64Encode } from "@opencode/util/encode"
import { terminalFontFamily, useSettings } from "@/settings/model"
import { extensionTabKey } from "./keys"
import { showToast } from "@/shell/notifications/toast"
import { ReviewDesktop } from "@opencode/plugin-review-desktop"
import type { SessionServices } from "@opencode/plugin/desktop/workspace"

export type Contribution = Claim<{
Expand Down Expand Up @@ -97,7 +98,7 @@ function createHost() {
const workspaceRemoved = new Set<(value: { serverID: string; directory: string }) => void>()
const attempted = new WeakSet<Plugin.Definition>()
let instanceID = 0
const builtins = () => platform.extensionPlugins ?? []
const builtins = () => [ReviewDesktop, ...(platform.extensionPlugins ?? [])]
createEffect(() => {
const manager = platform.extensionManager
if (!manager) return
Expand Down
25 changes: 1 addition & 24 deletions packages/app/src/home/projects/file-manager.ts
Original file line number Diff line number Diff line change
@@ -1,24 +1 @@
export type FileManagerOS = "macos" | "windows" | "linux" | "unknown"

export function fileManagerApp(os: FileManagerOS): {
label: "session.header.open.finder" | "session.header.open.fileExplorer" | "session.header.open.fileManager"
actionLabel:
| "session.header.reveal.finder"
| "session.header.reveal.fileExplorer"
| "session.header.reveal.containingFolder"
icon: "finder" | "file-explorer"
} {
if (os === "macos")
return { label: "session.header.open.finder", actionLabel: "session.header.reveal.finder", icon: "finder" }
if (os === "windows")
return {
label: "session.header.open.fileExplorer",
actionLabel: "session.header.reveal.fileExplorer",
icon: "file-explorer",
}
return {
label: "session.header.open.fileManager",
actionLabel: "session.header.reveal.containingFolder",
icon: "finder",
}
}
export { fileManagerApp, type FileManagerOS } from "@opencode/util/file-manager"
1 change: 1 addition & 0 deletions packages/app/src/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
@import "@opencode/session-ui/styles";
@import "@opencode/ui/styles/tokens";
@import "tw-animate-css";
@source "../../plugin-review-desktop/src";

@font-face {
font-family: "JetBrainsMono Nerd Font Mono";
Expand Down
15 changes: 0 additions & 15 deletions packages/app/src/session/commands/use-session-commands.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,6 @@ export const useSessionCommands = (actions: SessionCommandContext) => {
}
}

const openFile = () => {
void openDialog(
() => import("@/shell/commands/dialog"),
(x) => dialog.show(() => <x.DialogCommandPalette onOpenFile={showAllFiles} />),
)
}

const closeTab = () => {
const tab = actions.session.tabs.closableTab()
if (!tab) return
Expand Down Expand Up @@ -311,14 +304,6 @@ export const useSessionCommands = (actions: SessionCommandContext) => {
const fileCmds = () => {
const tab = actions.session.tabs.closableTab()
return [
fileCommand({
id: "file.open",
title: language.t("command.file.open"),
description: language.t("palette.search.placeholder"),
keybind: "mod+p",
slash: "open",
onSelect: openFile,
}),
tab &&
fileCommand({
id: "file.close",
Expand Down
20 changes: 0 additions & 20 deletions packages/app/src/session/files/open-in-app.test.ts

This file was deleted.

35 changes: 0 additions & 35 deletions packages/app/src/session/files/session-mobile-files.css

This file was deleted.

100 changes: 0 additions & 100 deletions packages/app/src/session/files/session-mobile-files.tsx

This file was deleted.

Loading
Loading