Open
Conversation
tjshiu
added
dev-app preview
|
Deployed dev-app for 910f18a to: https://ng-dev-previews-comp--pr-angular-components-32857-dev-8t8lg23d.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
tjshiu
force-pushed
the
pr-32502
branch
2 times, most recently
from
1b20888 to
bb39cca
Compare
…fine behavior - Adds new examples for simple-combobox: auto-select, highlight, disabled, readonly, and dialog popups. - Refactors existing datepicker and grid examples for better interaction patterns. - Introduces alwaysExpanded input to SimpleCombobox for persistent popup states. - Refines selection behavior in ListboxPattern when followFocus is enabled. - Cleans up unused inline-suggestion examples and console logs.
- Introduces a 'tabbable' input to Listbox and Tree to control whether the widget or its items are in the tab order. - Updates ListFocus and Tree behaviors to respect the 'tabbable' signal, defaulting tabIndex to -1 when false. - Updates simple-combobox examples to set [tabbable]="false" on internal widgets to ensure correct focus behavior. - Includes unit tests for the new tabbable behavior in ListFocus and Tree.
…tion logic - Adds extensive unit tests for SimpleCombobox across Listbox, Tree, and Grid implementations. - Refines aria-autocomplete calculation to exclude dialog-type popups, as they do not support autocomplete behavior. - Switches SimpleCombobox from pointerdown to click for popup triggering to improve interaction consistency. - Fixes ListFocus to properly focus the host element when using activedescendant mode. - Updates GridPattern to prevent resetting its default active state once a user has already interacted with it. - Moves alwaysExpanded initialization to ngOnInit in the public Combobox component for better lifecycle management. - Improves simple-combobox-highlight example to handle disabled states.
angular-robot
Bot
added
the
area: build & ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Simple Combobox pattern to the @angular/components ARIA package.
Key Changes & Features