docs: fix stale Bazel test targets and toolchain versions - #34161
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the developer documentation to reflect the new Node.js and pnpm version requirements, correct Bazel test targets, and fix a reference to the .monorepo.json file. The review feedback recommends clarifying the supported Node.js versions to avoid misleading users about unsupported odd-numbered versions, and suggesting the installation of the exact pnpm version (or using Corepack) to prevent engine mismatch errors.
2504308 to
695e880
Compare
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
PR Checklist
PR Type
What is the current behavior?
The contributor docs point at things that no longer exist:
docs/DEVELOPER.mduses//packages/schematics/angular:angular_testanddocs/process/bazel.mduses//packages/angular/cli:angular-cli_test. Neither target exists: thejasmine_testrules are namedtest(packages/schematics/angular/BUILD.bazel:137,packages/angular/cli/BUILD.bazel:172);angular_test_lib/angular-cli_test_libare the ts_projects they depend on.docs/DEVELOPER.mdsays Nodev20.19.0or higher andnpm i -g pnpm@9, butpackage.jsonenforcesnode: ^22.22.3 || ^24.15.0 || >=26.0.0andpnpm: 12.4.2(packageManager: pnpm@12.4.2).devkit:packageupdates the.monorepofile; the file is.monorepo.json.Issue Number: N/A
What is the new behavior?
The docs use the real target names, the enforced minimum Node and pnpm 12, and the right file name.
Does this PR introduce a breaking change?
Other information
AI assistance: found and prepared with Claude Code; I checked each target against the BUILD files and the versions against
package.jsonbefore opening.🤖 Generated with Claude Code