Skip to content

docs: fix stale Bazel test targets and toolchain versions - #34161

Merged
dgp1130 merged 1 commit into
angular:mainfrom
ZainnQureshii:docs/stale-developer-docs
Sep 24, 2026
Merged

dgp1130 merged 1 commit into
angular:mainfrom
ZainnQureshii:docs/stale-developer-docs

Conversation

@ZainnQureshii

Copy link
Copy Markdown
Contributor

PR Checklist

PR Type

  • Documentation content changes

What is the current behavior?

The contributor docs point at things that no longer exist:

  • docs/DEVELOPER.md uses //packages/schematics/angular:angular_test and docs/process/bazel.md uses //packages/angular/cli:angular-cli_test. Neither target exists: the jasmine_test rules are named test (packages/schematics/angular/BUILD.bazel:137, packages/angular/cli/BUILD.bazel:172); angular_test_lib / angular-cli_test_lib are the ts_projects they depend on.
  • docs/DEVELOPER.md says Node v20.19.0 or higher and npm i -g pnpm@9, but package.json enforces node: ^22.22.3 || ^24.15.0 || >=26.0.0 and pnpm: 12.4.2 (packageManager: pnpm@12.4.2).
  • It also says devkit:package updates the .monorepo file; the file is .monorepo.json.

Issue Number: N/A

What is the new behavior?

The docs use the real target names, the enforced minimum Node and pnpm 12, and the right file name.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

AI assistance: found and prepared with Claude Code; I checked each target against the BUILD files and the versions against package.json before opening.

🤖 Generated with Claude Code

@google-cla

google-cla Bot commented Sep 24, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot Bot added the area: docs Related to the documentation label Sep 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the developer documentation to reflect the new Node.js and pnpm version requirements, correct Bazel test targets, and fix a reference to the .monorepo.json file. The review feedback recommends clarifying the supported Node.js versions to avoid misleading users about unsupported odd-numbered versions, and suggesting the installation of the exact pnpm version (or using Corepack) to prevent engine mismatch errors.

@angular angular deleted a comment from gemini-code-assist Bot Sep 24, 2026
@angular angular deleted a comment from gemini-code-assist Bot Sep 24, 2026
@ZainnQureshii
ZainnQureshii force-pushed the docs/stale-developer-docs branch from 2504308 to 695e880 Compare September 24, 2026 14:29

@alan-agius4 alan-agius4 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 24, 2026
@dgp1130
dgp1130 merged commit d968259 into angular:main Sep 24, 2026
41 checks passed
@dgp1130

dgp1130 commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants