fix(@angular/cli): gracefully handle package manager errors in command handler#33462
Open
alan-agius4 wants to merge 1 commit into
Open
fix(@angular/cli): gracefully handle package manager errors in command handler#33462alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
alan-agius4
added
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request centralizes the error handling for PackageManagerError by moving the catch block from the individual AddCommandModule to the base CommandModule handler, while also simplifying logger usage and autocompletion setup. The review feedback suggests improving the formatting of the logged error message in CommandModule to only append the 'Output' section if stdout or stderr actually contains content, preventing empty output lines.
…d handler Catch `PackageManagerError` in the global `CommandModule` handler and gracefully log the installation failure message along with the process output (stdout/stderr) using `logger.fatal`. This ensures that any package manager error thrown during the execution of a command is reported cleanly to the terminal and sets the exit code to 1.
alan-agius4
force-pushed
the
fix/error-logging
branch
from
181f1e6 to
f722aff
Compare
clydin
approved these changes
Jun 25, 2026
alan-agius4
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch
PackageManagerErrorin the globalCommandModulehandler and gracefully log the installation failure message along with the process output (stdout/stderr) usinglogger.fatal.This ensures that any package manager error thrown during the execution of a command is reported cleanly to the terminal and sets the exit code to 1.