Repository navigation
fix: version comparison logic for remote update checks - #543
Open
eduardomozart wants to merge 1 commit into
Open
eduardomozart wants to merge 1 commit into
eduardomozart wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the application would prompt the user to download an "older" stable version if the user was running a newer patch version (e.g., prompting to downgrade from
3.10.1to3.10.0).Previously, the version check in
HelpMenuActions.javarelied on simple string equality (!Version.getVersion().equals(latestVersion)). This evaluates to true anytime the running version differs from the remote version, regardless of which one is newer.Changes
compareTomethod inVersion.javathat handles semantic version string comparison by evaluating their numeric parts.HelpMenuActions.javato use the newcompareTomethod, ensuring the update prompt only appears when the current version is strictly older than the latest stable remote version (Version.compareTo(current, latest) < 0).VersionTest.javato verify the new version comparison logic against multiple scenarios (e.g., standard versions, omitted patch numbers, and betas).Testing
VersionTestcovers the comparison logic.