Repository navigation
feat(windows): add per-user/per-machine installation and multilingual support - #541
Open
eduardomozart wants to merge 8 commits into
Open
eduardomozart wants to merge 8 commits into
eduardomozart wants to merge 8 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Windows NSIS installer to allow users to choose between a per-user installation ("Just for me", which does not require UAC elevation) and a per-machine installation ("For anyone", which prompts for UAC elevation). Closes #540.
It leverages the NsisMultiUser plugin to properly handle registry views, uninstaller entries, and dynamic
$INSTDIRswitching. Additionally, it introduces auto-detected multilingual support for the installer interface, matching the translations already supported by the application.Changes
NsisMultiUseras a git submodule inext/win-installer/NsisMultiUser.Installer.nsito useMULTIUSERmacros for initialization and uninstallation.!define MULTIUSER_INSTALLMODE_64_BIT 1. Since thewin64gradle task bundles a 64-bit JRE andx86_64SWT, this ensures the app correctly installs toProgram Filesinstead ofProgram Files (x86)on per-machine installations..github/workflows/build.ymlto includesubmodules: recursivein the checkout steps, ensuring the CI runner successfully fetches theNsisMultiUserdependency during the build process.MUI_LANGUAGEmacros to the installer (matching the supported locales inLabels.LANGUAGES). The installer will now natively auto-detect the user's OS language and fallback to English when unsupported.Dependencies & Notes
Note: The installer itself compiles and works exactly as expected. However, when launching the application on Windows, it crashes on startup with an
UnsatisfiedLinkError(swt-gdip-win32missing). This PR requires Include swt-gdip-*.dll in Windows build #534 to be merged in order for the resulting Windows executable to run properly.