Skip to content

Support new color functions for HSL shift#83

Open
maxmmitchell wants to merge 1 commit into
mainfrom
support-new-color-functions
Open

Support new color functions for HSL shift#83
maxmmitchell wants to merge 1 commit into
mainfrom
support-new-color-functions

Conversation

@maxmmitchell

@maxmmitchell maxmmitchell commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

With 1.1.0-alpha04, we got new color functions:

  • Hue offset
  • Saturation multiplier
  • Luminosity offset

This change adds support for these color functions in brush graph, so we can load brushes that use these new features, and edit them. A lot of formatting changes also got picked up on save in TooltipsTest.kt.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request expands the color function capabilities in the brush graph UI by adding support for hue offset, saturation multiplier, and luminosity offset. It refactors the display string resolution for ProtoColorFunction into an extension function and updates the corresponding UI fields, tooltips, and tests. Feedback on the changes includes fixing a UI rendering bug where an empty or default ProtoColorFunction results in no numeric field being displayed, displaying the luminosity offset as a percentage instead of a raw float for consistency, and explicitly checking hasLuminosityOffset() in displayStringRId() for better code readability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@maxmmitchell maxmmitchell force-pushed the support-new-color-functions branch 2 times, most recently from 399e514 to 7c434c8 Compare June 25, 2026 16:42
@maxmmitchell maxmmitchell force-pushed the support-new-color-functions branch from 7c434c8 to 31a0336 Compare June 25, 2026 16:46
@maxmmitchell maxmmitchell marked this pull request as ready for review June 25, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant