As recommended in the idling resource analysis doc, IdlingResource implementations should call onTransitionToIdle after configuring isIdleNow.#2483
Open
copybara-service[bot] wants to merge 1 commit into
Conversation
…plementations should call onTransitionToIdle after configuring isIdleNow. The instrumentation implementation previously threw an IllegalStateException if it observed a transition to idle without onTransitionToIdle being called first. This is downgraded to a warning to avoid flakiness and support the recommended order of operations. Documentation in IdlingResource is updated to reflect this recommendation. PiperOrigin-RevId: 913798608
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As recommended in the idling resource analysis doc, IdlingResource implementations should call onTransitionToIdle after configuring isIdleNow.
The instrumentation implementation previously threw an IllegalStateException if it observed a transition to idle without onTransitionToIdle being called first. This is downgraded to a warning to avoid flakiness and support the recommended order of operations.
Documentation in IdlingResource is updated to reflect this recommendation.