Skip to content

arm/arm64: dts: adi: fix gpio-hog polarity on sc5xx boards#3370

Merged
jiez merged 1 commit into
adsp-6.18.31-yfrom
adsp-sc5xx-fix-gpio-hog-polarity
Jun 26, 2026
Merged

arm/arm64: dts: adi: fix gpio-hog polarity on sc5xx boards#3370
jiez merged 1 commit into
adsp-6.18.31-yfrom
adsp-sc5xx-fix-gpio-hog-polarity

Conversation

@jiez

@jiez jiez commented Jun 12, 2026

Copy link
Copy Markdown

On SC573 EZLITE board, all MCP23017 expander enable signals are active-low. Replace GPIO_ACTIVE_HIGH with GPIO_ACTIVE_LOW throughout and change output-low/output-high accordingly to keep the previous default behavior.

Also add missing audio-jack-sel hog for SC573 EZLITE board.

For SC594/SC598 SOM EZKIT boards, remove audio-jack-sel hog, which is not on schematics, and fix mlb-en polarity.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes only on the SC598 SOM EZKIT board
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

@jiez jiez requested review from a team June 12, 2026 03:41
On SC573 EZLITE board, all MCP23017 expander enable signals are
active-low. Replace GPIO_ACTIVE_HIGH with GPIO_ACTIVE_LOW throughout
and change output-low/output-high accordingly to keep the previous
default behavior.

Also add missing audio-jack-sel hog for SC573 EZLITE board.

For SC594/SC598 SOM EZKIT boards, remove audio-jack-sel hog, which
is not on schematics, and fix mlb-en polarity.

Signed-off-by: Jie Zhang <jie.zhang@analog.com>
@jiez jiez force-pushed the adsp-sc5xx-fix-gpio-hog-polarity branch from 2ddad64 to ebaaf08 Compare June 18, 2026 17:01
@jiez jiez added this to ADSP Jun 18, 2026
@jiez jiez changed the base branch from adsp-6.12.0-y to adsp-6.18.31-y June 18, 2026 17:07
@jiez jiez moved this to In Development in ADSP Jun 18, 2026
@jiez jiez closed this Jun 18, 2026
@github-project-automation github-project-automation Bot moved this from In Development to Done in ADSP Jun 18, 2026
@jiez jiez reopened this Jun 18, 2026
@jiez jiez self-assigned this Jun 18, 2026
@jiez jiez force-pushed the adsp-sc5xx-fix-gpio-hog-polarity branch from df11acc to ebaaf08 Compare June 18, 2026 21:35
@jiez jiez changed the base branch from adsp-6.18.31-y to adsp-6.12.0-y June 18, 2026 22:08
@jiez jiez changed the base branch from adsp-6.12.0-y to adsp-6.18.31-y June 18, 2026 22:09
@pamolloy pamolloy moved this from Done to In Development in ADSP Jun 19, 2026
@pamolloy pamolloy added the llm review Request a review from a LLM Reviewer label Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

LLM review

This series fixes gpio-hog polarity descriptors on SC5xx evaluation boards, correcting GPIO_ACTIVE_HIGHGPIO_ACTIVE_LOW annotations on MCP23017 expander pins while inverting output-highoutput-low to preserve physical pin states. It also adds a missing audio-jack-sel hog on the SC573 EZ-KIT and removes erroneous audio-jack-sel hogs from SC594/SC598 SOM EZ-KIT boards.

run: 28013128762

ebaaf08d - arm/arm64: dts: adi: fix gpio-hog polarity on sc5xx boards

The gpio-hog semantics were reviewed against drivers/gpio/gpiolib.c: output-low/output-high refer to logical levels; when GPIO_ACTIVE_LOW is set, gpiod_direction_output_nonotify() inverts the value, so ACTIVE_LOW + output-low → physical HIGH and ACTIVE_LOW + output-high → physical LOW. All signal transitions are verified to preserve the physical pin state.

The SC573 EZ-KIT schematic (adsp-sc573_ez-kit_schematic-rel_1-3.pdf) confirms:

  • MLB3_EN is active-low (schematic: "MLB3_EN Low for Board Option 3") — physical HIGH default is correct.
  • AUDIO_JACK_SEL is a level selector, not an active-low enable (schematic: "High for input") — GPIO_ACTIVE_HIGH + output-high producing physical HIGH (input mode) is intentional and correct.
  • MCP23017 U47/U48 pin-to-signal mapping matches the DTS.

The commit description says "all MCP23017 expander enable signals are active-low" — this is slightly imprecise since audio-jack-sel on the SC573 deliberately uses GPIO_ACTIVE_HIGH, but it has no effect on correctness.

CI warnings

The dtc warnings for sc573-ezlite.dts (duplicate unit-address on core{1,2}-rproc, missing reg on sound, channel@N unit-address-vs-reg) and for sc598-som.dtsi are pre-existing structural issues at lines untouched by this patch. They are not introduced by this series.

Verification data

The SC573 EZ-KIT schematic (adsp-sc573_ez-kit_schematic-rel_1-3.pdf) was fetched from https://www.analog.com/media/en/technical-documentation/eval-board-schematic/ and extracted with PyMuPDF to verify signal polarities. DTBs were built clean for sc573-ezlite_defconfig (ARM), sc594-som-ezkit_defconfig (ARM), and sc598-som-ezkit_defconfig (AArch64) using the CI build toolchain — no errors, no new warnings.

@jiez jiez merged commit be22560 into adsp-6.18.31-y Jun 26, 2026
52 of 56 checks passed
@jiez jiez deleted the adsp-sc5xx-fix-gpio-hog-polarity branch June 26, 2026 04:24
@github-project-automation github-project-automation Bot moved this from In Development to Done in ADSP Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llm review Request a review from a LLM Reviewer

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants