Update Linux install instructions#991
Conversation
|
|
||
| ### Programs to be installed manually | ||
| To do this, make sure `curl` is installed (and if not, run `sudo apt install curl`). Then running the following command will install vrecord dependencies: | ||
|
|
There was a problem hiding this comment.
You could also add a test in the linux-dependencies.sh script and, if not already installed, do it.
There was a problem hiding this comment.
Bit of a catch-22 though, because ideally people will use curl to run linux-dependencies.sh, so can't really have it run a check to see if curl is present if they need curl to run it.
There was a problem hiding this comment.
Indeed! Then my nit is void.
There was a problem hiding this comment.
If curl is not yet installed, then wget would also do the trick:
wget -O - https://raw.githubusercontent.com/amiaopensource/vrecord/refs/heads/linux-doc-updates/Release/linux-dependencies.sh | bash
I guess, wget comes with Ubuntu? If that is correct, then wget could check and when needed install curl.
(I personally prefer curl for many reasons.)
There was a problem hiding this comment.
Good point - wget is included out of the box. I think I'll shift the recommended command here to wget and then add curl into the dependencies script. I don't think it's even necessary to do a check really, as apt-get will just skip it if it is already installed. Either way, curl is necessary for running the following Homebrew install step, so it will have to be installed one way or another.
There was a problem hiding this comment.
Just made that change and squished it - thanks for the suggestion!
There was a problem hiding this comment.
Good point indeed, apt-get needs it!
6c3bf2c to
ec0863a
Compare
dericed
left a comment
There was a problem hiding this comment.
LGTM. thx for all this documentation
Updated Linux install docs to simplify the process and remove out of date information - this process is working in my VM test so far.