You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @joeysk2012, thanks for the question — happy to expand on the rationale.
A .gitignore at the repo root is a near-universal convention across the
AWS GitHub orgs, not a custom workflow file. From a quick survey across aws/, awslabs/, and aws-samples/, every prominent repo I checked
(aws-cli, aws-cdk, aws-sam-cli, aws-sdk-go-v2, aws-sdk-rust, jsii, s2n-tls, serverless-application-model, mcp, llrt, mountpoint-s3, deequ, swift-aws-lambda-runtime, aws-cdk-examples, amazon-sagemaker-examples, …) ships one. Within amazonlinux/ itself, amazonlinux/smart-restart already commits a .gitignore that includes *.code-workspace, which is one of the entries proposed here.
The contents I'm proposing also aren't custom — they mirror what other
AWS-owned repos already exclude:
*.DS_Store is excluded in essentially every AWS .gitignore I looked at
(aws-cli, aws-cdk, aws-sdk-go-v2, aws-sdk-rust, mcp, llrt, aws-cdk-examples, etc.).
.vscode / .vscode/* is excluded in aws-cdk, aws-sam-cli, s2n-tls, aws-sdk-go-v2, aws-sdk-rust, deequ, aidlc-workflows, swift-aws-lambda-runtime, nx-plugin-for-aws, and many aws-samples.
.kiro is explicitly excluded in aws/aws-cdk, aws/aws-sam-cli, aws/aws-durable-execution-sdk-java, awslabs/mcp, awslabs/swift-aws-lambda-runtime, awslabs/nx-plugin-for-aws, and aws-samples/sample-collaborative-ai-dlc — it is now an established
convention across AWS orgs.
/.devcontainer/ and *.code-workspace appear (or close analogues
appear) in awslabs/swift-aws-lambda-runtime, awslabs/nx-plugin-for-aws, aws/aws-sam-cli, and amazonlinux/smart-restart.
The closest precedent to this exact PR inside Amazon's own orgs is awslabs/swift-aws-lambda-runtime, whose .gitignore excludes .DS_Store, .vscode, .devcontainer, and .kiro — i.e. essentially
the same set proposed here.
The change is purely additive (no behaviour change, no build impact, just
preventing IDE/OS noise from leaking into PRs from any contributor that
uses these tools). It matches the prevailing convention in the same GitHub
organisations and helps keep future PRs clean. Happy to adjust the contents
to match the exact pattern preferred by maintainers (e.g. drop or rename any
specific entry) if that's the concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a .gitignore file to exclude common development artifacts from version control:
.devcontainer/).vscode,.cursor,.kiro,*.code-workspace)*.DS_Store)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.