Repository navigation
FLUX-803 - Support PHP 8.5 - #7
Merged
Merged
Conversation
The test faked limit=1 while getAmazonResults() defaults to limit=1000, so the fake never matched. preventStrayRequests() ran before refreshApplication(), which discards it, so the unmatched request reached the real API and the test failed on its HTML response. main's run-tests has failed on every run since at least 2026-01-30 for this reason.
Adds ~8.5.0 to the php constraint, keeping the per-minor style, and runs the test matrix on PHP 8.3, 8.4 and 8.5 with fail-fast off so one version's result does not cancel the others.
Laravel's HTTP client Response now defines getStatusCode(), so the ignored error is no longer reported, and phpstan fails on the unmatched ignore pattern. With current dependencies main fails the same way; this is not caused by the 8.5 change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"php": "~8.3.1|~8.4.1|~8.5.0", keeping the existing per-minor style.run-testsmatrix now covers PHP 8.3, 8.4 and 8.5 (it was 8.3 only), withfail-fast: false.mainred.run-testsonmainhas failed on every run since at least 2026-01-30:BwtApiClientTestfaked…/123/results?limit=1&offset=0, butgetAmazonResults()defaults tolimit=1000, so the fake never matched.BaseTest::setUp()calledHttp::preventStrayRequests()beforerefreshApplication(). That builds a new app and discards the setting, so the unmatched request reached the real bwt.com, and the test failed on its HTML response.preventStrayRequests()runs afterrefreshApplication(). Checked by restoring the old URL: the test now fails withAttempted request to [https://bwt.com/api/123/results?limit=1000&offset=0] without a matching fake, with no network call.Testing
Ran
composer update --prefer-stableandcomposer testinphp:<v>-clicontainers, as CI does:On unmodified
main, the same run fails withAPI request failed: <!DOCTYPE html>….Ticket: FLUX-803
Illuminate\Http\Client\ResponsedefinesgetStatusCode(), so phpstan failed with "Ignored error pattern … was not matched". Unmodifiedmainfails the same way today. phpstan is clean on 8.3, 8.4 and 8.5 after removing it.