Drop sys/time.h and unistd.h#343
Open
wegank wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
The failing test is reproducible on my aarch64-windows machine with the given seed. $ ./msolve.exe -f input_files/eco10-31.ms -o out.ms --random-seed 1779878689 -P 2 -d 0 -L 0 -l 44 -t 1 -v 2
Initial seed for pseudo-random number generator is 1779878689
...
------------------------------------------------------------------------------------
msolve overall time 1.71 sec (elapsed) / 1.71 sec (cpu)
------------------------------------------------------------------------------------
$ cat out.ms
$I can look at it in two weeks. Otherwise, since Windows is Tier 3, this should not block the PR. |
Contributor
Author
|
Oh, actually this is not Windows-specific; I can reproduce on macOS by modifying the rand function. I'll open an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I'm not mistaken,
unistd.hwas never actually used, and we only usegettimeofdayfromsys/time.h, which can easily be replaced with the modern (and more accurate)timespec_getfrom the already-importedtime.h. So we can drop them both, I think?