Repository navigation
🐛 Stop a malformed zip64 record bypassing the error event - #2
Closed
alecgibson wants to merge 1 commit into
Closed
alecgibson wants to merge 1 commit into
alecgibson wants to merge 1 commit into
Conversation
Fixes antelle#112 At the moment, a crafted archive can make the central-directory reader throw synchronously from inside an `fs.read` callback, which surfaces as an `uncaughtException` rather than an `error` event. A caller with correct error handling still has its process taken down by a malformed file. `op.complete` is assigned three completion handlers, and only one of them — `readCentralDirectoryComplete` — guards itself. Since all three are reached through the single `op.complete()` call in `readUntilFoundCallback`, guarding that one statement covers every path, and any handler added later. That leaves the try/catch in `readCentralDirectoryComplete` redundant, but removing it would mean re-indenting the whole function, so it stays. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
Opened against the wrong base repo; superseded by antelle#114. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes antelle#112
At the moment, a crafted archive can make the central-directory reader throw synchronously from inside an
fs.readcallback, which surfaces as anuncaughtExceptionrather than anerrorevent. A caller with correct error handling still has its process taken down by a malformed file.op.completeis assigned three completion handlers, and only one of them —readCentralDirectoryComplete— guards itself. Since all three are reached through the singleop.complete()call inreadUntilFoundCallback, guarding that one statement covers every path, and any handler added later. That leaves the try/catch inreadCentralDirectoryCompleteredundant, but removing it would mean re-indenting the whole function, so it stays.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com