feat!: support zig 0.16 by cerisier · Pull Request #635 · aherrmann/rules_zig

cerisier · 2026-04-27T13:17:24Z

Closes #625

This PR is a mix of upstream of zml/rules_zig + additional fixes to comply with current aherrmann/rules_zig.
It's mainly porting all zig source code to support zig 0.16.x AND zig 0.15.x

The only changes non related to tests are:

Drops support for zig version 0.14.x
Defaults to zig version 0.16.0
passing GLOBAL_CACHE_DIR and related by env to zig and zig translate-c instead of CLI args since in zig 0.16, those variables are not always read from the CLI args (I think it's a bug from zig).

BREAKING CHANGE

Removes support for 0.14.x.
Changes the runfiles API for 0.16.x support.

cerisier · 2026-04-27T13:24:26Z

@aherrmann I think this somehow surfaces that the removal of cc_common.link hack makes bazel 8 fail ?

aherrmann · 2026-04-27T15:08:23Z

@aherrmann I think this somehow surfaces that the removal of cc_common.link hack makes bazel 8 fail ?

I haven't looked at the changes, yet. But, I encountered the same issue in the Bazel 9 upgrade PR and therefore kept the workaround alive: 02914a0

cerisier · 2026-04-27T15:22:16Z

I think there is another issue then because this PR is rebased on main@HEAD.

aherrmann

I'm only about half-way through, but pushing these comments already.

cerisier · 2026-04-27T16:22:50Z

@aherrmann I think this somehow surfaces that the removal of cc_common.link hack makes bazel 8 fail ?

I haven't looked at the changes, yet. But, I encountered the same issue in the Bazel 9 upgrade PR and therefore kept the workaround alive: 02914a0

Ok so actually this has been there since rules_cc 0.2.18.
But the tests that would make it surface were incompatible with 0.15.2 so they never ran and so never failed...

I'm not 100% sure but it seems that the issue is because the tools/build_defs/android package hack only works inside the main repo. When rules_zig is pulled transitively, this wouldn't work.

cerisier · 2026-04-27T16:23:58Z

I'm only about half-way through, but pushing these comments already.

Thanks for the valid points ! changes were so wide things got lost.

It makes me wonder if we should provide support for previous Zig versions.

cerisier · 2026-04-27T16:57:18Z

All first review addressed

It is not automatically tested, but, the purpose of those tests is to check that docs generation works properly, and the source doc strings make their way into the generated docs.

cerisier · 2026-04-28T11:29:18Z

Fixed and green

The runfiles decltest is meant as an example how to use the library. As such it shouldn't use testutils, since those won't be available to users.

aherrmann

Thank you for putting this together! Some small comments. I also found and fixed a remote execution failure with the runfiles decltest.

aherrmann · 2026-04-28T08:44:44Z

@@ -1,133 +0,0 @@
-{


This one should not be left empty, but should be updated to the latest 0.17 dev. Otherwise, we're not testing the extra-versions feature.

aherrmann · 2026-04-28T08:45:21Z

-zig.index(file = "extra-versions.json")
-zig.toolchain(zig_version = "0.16.0-dev.381+bc512648d")


Needs to be updated to a 0.17 dev test.

aherrmann · 2026-04-28T08:47:09Z

 )

-TEST_VERSIONS = TOOL_VERSIONS.keys() + [
-    "0.16.0-dev.381+bc512648d",


same here re 0.17 dev test.

aherrmann · 2026-04-28T08:59:53Z


 test "zig_target_toolchain attribute dynamic_linker configures the interpreter" {
+    if (true) {
+        // Zig 0.16 rejects custom dynamic linkers for some compiler sub-steps.


Is this related to https://codeberg.org/ziglang/zig/issues/31760 ?
Does it fail on all test platforms or just some? I.e. is it possible to keep this test alive on platforms where it works, or is it completely unsupported by Zig 0.16?

Gating this only for 0.16 instead of skipping all the time. Sadly, this happens all the time in zig 0.16 for subcompilation steps like compiler-rt or libc (in which this test is about), start files etc...

Co-authored-by: Andreas Herrmann <andreash87@gmx.ch>

cerisier · 2026-04-28T15:36:22Z

Finally green !

cerisier added 18 commits April 24, 2026 14:29

Zig 0.16 syntax change

7e10d96

Support stable Zig 0.16 integration tests

e3bda27

Drop Zig 0.14 support

e409e95

0.16 fix

6e2f1dc

last

41c68c4

Merge remote-tracking branch 'origin/main' into upstreamable-zig-0.16

d4b131b

integrations

465117b

better-env

fde4653

pass env to translate-c

9f7df0e

Fix remaining e2e tests

72c4008

Use init where it makes sense in runfiles

8122bdd

fixup integratino

b5522c7

fixup workspace tests

a29aa14

more cleaning runfiles

cddd2e5

entrypoint branches

23c1cfa

simplification

03a4359

more clean

a0d732b

Merge remote-tracking branch 'origin/main' into upstreamable-zig-0.16

a6423d3

aherrmann reviewed Apr 27, 2026

View reviewed changes

cerisier added 2 commits April 27, 2026 16:36

initial review fixes

fe38d4b

Fix sentinel handling in non tests

ac03146

cerisier and others added 3 commits April 27, 2026 21:38

Merge remote-tracking branch 'origin/main' into upstreamable-zig-0.16

17598f8

restore zig-docs test

c929516

It is not automatically tested, but, the purpose of those tests is to check that docs generation works properly, and the source doc strings make their way into the generated docs.

Revert back to specific error type

b1032ff

cerisier added 2 commits April 28, 2026 10:21

fix

bc007eb

trigger

0c4138b

runfiles decltest is documentation

f3e1b75

The runfiles decltest is meant as an example how to use the library. As such it shouldn't use testutils, since those won't be available to users.

aherrmann reviewed Apr 28, 2026

View reviewed changes

aherrmann changed the title ~~feat: support zig 0.16~~ feat!: support zig 0.16 Apr 28, 2026

cerisier and others added 8 commits April 28, 2026 14:14

Update zig/runfiles/src/discovery.zig

ab537a9

Co-authored-by: Andreas Herrmann <andreash87@gmx.ch>

Update zig/runfiles/src/discovery.zig

76b7251

Co-authored-by: Andreas Herrmann <andreash87@gmx.ch>

Update zig/tests/strip_debug_symbols/main.zig

0f7a5a3

Co-authored-by: Andreas Herrmann <andreash87@gmx.ch>

0.17

62aa40d

gfix

ee0e610

Skip custom interpreter test for zig 0.16

568061e

trigger

e69891d

trigger

dff8848

		zig.index(file = "extra-versions.json")
		zig.toolchain(zig_version = "0.16.0-dev.381+bc512648d")

Conversation

cerisier commented Apr 27, 2026 • edited by aherrmann Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cerisier commented Apr 27, 2026

Uh oh!

aherrmann commented Apr 27, 2026

Uh oh!

cerisier commented Apr 27, 2026

Uh oh!

aherrmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cerisier commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cerisier commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cerisier commented Apr 27, 2026

Uh oh!

cerisier commented Apr 28, 2026

Uh oh!

aherrmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aherrmann Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aherrmann Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

aherrmann Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

aherrmann Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

cerisier Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cerisier commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cerisier commented Apr 27, 2026 •

edited by aherrmann

Loading

cerisier commented Apr 27, 2026 •

edited

Loading

cerisier commented Apr 27, 2026 •

edited

Loading

aherrmann Apr 28, 2026 •

edited

Loading