Repository navigation
tests: re-mint expired grant fixtures, guard against the expiry cliff - #18
Merged
Merged
Conversation
Every committed grant fixture expired on 2026-08-20 (30-day window, minted mid-July). Since then test_valid_grant and three siblings fail on every branch -- and worse, the tampered/revoked/wrong-geoid tests kept passing vacuously: the verifier rejected those credentials for expiry, not for the property under test. The conftest docstring claimed "no expiry cliff"; that was true only of the authority credentials it mints fresh each run. Fixtures re-minted with a 365-day window via the pancake testkit minter (needs agstack/pancake#8 for the --days flag). conftest now refuses to run when any non-expired-by-design fixture is within 30 days of expiry, and the error names the exact re-mint command. The guard was demonstrated failing against the old fixtures before the re-mint (lessons ledger: gate-reports-green-while-blind). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Guard demonstration (run before the re-mint, against the expired fixtures on main): all four fixtures reported -7 days of validity and the guard raised with the re-mint command; after re-minting with --days 365 it passes. Merge order: agstack/pancake#8 provides the --days flag this re-mint used, then this, then #17 re-runs green. |
3 tasks
…while-blind Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests: re-mint expired grant fixtures, guard against the expiry cliff
Every committed grant fixture expired on 2026-08-20 (30-day window,
minted mid-July). Since then test_valid_grant and three siblings fail on
every branch -- and worse, the tampered/revoked/wrong-geoid tests kept
passing vacuously: the verifier rejected those credentials for expiry,
not for the property under test. The conftest docstring claimed "no
expiry cliff"; that was true only of the authority credentials it mints
fresh each run.
Fixtures re-minted with a 365-day window via the pancake testkit minter
(needs agstack/pancake#8 for the --days flag). conftest now refuses to
run when any non-expired-by-design fixture is within 30 days of expiry,
and the error names the exact re-mint command. The guard was demonstrated
failing against the old fixtures before the re-mint (lessons ledger:
gate-reports-green-while-blind).