refactor(model): move DashScope/Ollama model provider from core to extensions module#1947
Merged
chickenlj merged 4 commits intoJun 29, 2026
Conversation
chickenlj
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues the model adapter modularization work by moving DashScope and Ollama model implementations out of
agentscope-coreinto dedicatedagentscope-extensions-model-*modules. It also moves the former core E2E test suite into a new model-extension E2E test module, and adds.editorconfigto enforce UTF-8 without BOM.Major Changes
DashScope model extension
agentscope-extensions-model-dashscope.DashScopeMultiModalToolfrom core into the new extension module.DashScopeModelProviderSPI registration.dashscope:.+qwen.+dashscope-sdk-javadependency from core.baseUrlsupport to DashScope Spring Boot properties and related tests.Ollama model extension
agentscope-extensions-model-ollama.OllamaModelProviderSPI registration.ollama:.+via SPI.Core cleanup
ModelRegistry.ModelRegistrynow resolves named models, user-registered factories, and SPI providers only.ModelRegistryTestand credential tests accordingly.agentscope-core/pom.xml.E2E test migration
agentscope-extensions-model-e2e-tests.io.agentscope.core.e2etest suite into the new model-extension E2E module.ENABLE_E2E_TESTS=trueplus provider API keys.Packaging and downstream updates
.editorconfigwith UTF-8 settings to avoid UTF-8 BOM regressions.Provider consistency
supports(modelId)increate. Standardized provider matching to usePattern.matcher(modelId).matches().