fix(harness): stream sandbox uploads through tar#1881
Open
guslegend0510 wants to merge 9 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
AgentScopeJavaBot
added
enhancement
AgentScopeJavaBot
left a comment
AgentScopeJavaBot
left a comment
Collaborator
There was a problem hiding this comment.
🤖 AI Review
Fixes #1876: Changes sandbox uploads from base64-inlined shell commands to tar stream hydration, removing Windows command-line length limit. Approach is correct. Verify SubAgentToolTimeoutRetryIntegrationTest.java compiles cleanly - old file-based assertions may conflict with new latch-based ones.
| "Invocations should be frozen at %d. Agent loop did not restart." | ||
| .formatted(invocations)); | ||
| // ---- proof #2: cancellation propagates to the inner tool execution ---- | ||
| // Since sink.onCancel(lifecycleDisposable) properly disposes the inner |
Collaborator
There was a problem hiding this comment.
[critical] Verify that old file-based assertions (referencing removed tmpFile field, Files/Path imports) have been properly removed. Coexistence with new latch/counter assertions may cause compilation failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.0-SNAPSHOT
Description
This PR fixes #1876.
On Windows, large SessionTree mirror uploads in the Docker sandbox could hit
CreateProcess error=206becauseSandboxBackedFilesystem.uploadFiles()inlined file contents as Base64 into adocker execcommand.The fix changes sandbox uploads to stream each file as a single-file tar archive and hydrate it through
Sandbox.hydrateWorkspace(InputStream)instead of passing the payload through the command line. This removes the Windows command-line length limit from session mirror uploads while keeping existing sandbox behavior unchanged.A regression test was added to verify that uploads go through tar hydration and no longer shell out via
exec().How to test
mvn -pl agentscope-harness -am -Dtest=SandboxBackedFilesystemTest test
Related issues
Fixes #1876