fix: show disconnected profiles in plain output, offer sync-to-chrome interactively - #502
Merged
Merged
Conversation
Plain-text `profile list` returned early on zero connected runtimes, hiding aliases that already existed in config.
`webcmd setup` only honored --sync-to-chrome as a flag, so interactive chrome selection never asked whether to export profiles into native Chrome.
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs found while manually testing the just-released v0.8.3 Chrome-export feature:
1.
webcmd profile list(plain-text output) hides saved-but-disconnected profiles when zero are currently connectedprofiles.length === 0alone, before ever consulting the saved alias registry — so a profile created viaprofile createbut never launched was completely invisible in the default output, even though the structured (-f json) output already showed it correctly viaprofileListRows().config.aliasesandconfig.defaultContextIdbefore deciding there's nothing to show.2.
webcmd setupnever offers--sync-to-chromeinteractivelyLocal browser [cloak/chrome/slab/absolute path]prompt never mentions or asks about sync-to-chrome — unlike--import-chrome-cookies, which does get an interactive[Y/n]prompt. The only way to discover the feature was already knowing the flag name.[y/N]prompt (defaults to no, since it writes real files into the user's native Chrome directory — a bigger behavior change than cookie import), asked only when browser is chrome, the flag wasn't passed either way, and the session is interactive.Test plan
runner.test.tsbrowser-context contention under high system load — every flaky file passes cleanly alone)npm run typecheck— clean🤖 Generated with Claude Code