Skip to content

fix: show disconnected profiles in plain output, offer sync-to-chrome interactively - #502

Merged
ankitranjan7 merged 2 commits into
mainfrom
fix/profile-list-and-sync-prompt
Sep 8, 2026
Merged

fix: show disconnected profiles in plain output, offer sync-to-chrome interactively#502
ankitranjan7 merged 2 commits into
mainfrom
fix/profile-list-and-sync-prompt

Conversation

@ankitranjan7

Copy link
Copy Markdown
Contributor

Summary

Two bugs found while manually testing the just-released v0.8.3 Chrome-export feature:

1. webcmd profile list (plain-text output) hides saved-but-disconnected profiles when zero are currently connected

  • The early-return guard fired on profiles.length === 0 alone, before ever consulting the saved alias registry — so a profile created via profile create but never launched was completely invisible in the default output, even though the structured (-f json) output already showed it correctly via profileListRows().
  • Fix: the guard now also checks config.aliases and config.defaultContextId before deciding there's nothing to show.

2. webcmd setup never offers --sync-to-chrome interactively

  • Picking "chrome" at the interactive Local browser [cloak/chrome/slab/absolute path] prompt never mentions or asks about sync-to-chrome — unlike --import-chrome-cookies, which does get an interactive [Y/n] prompt. The only way to discover the feature was already knowing the flag name.
  • Fix: added an equivalent [y/N] prompt (defaults to no, since it writes real files into the user's native Chrome directory — a bigger behavior change than cookie import), asked only when browser is chrome, the flag wasn't passed either way, and the session is interactive.

Test plan

  • Full suite: 206/206 test files, 3652 passed, 2 skipped (confirmed under reduced worker concurrency; full-parallelism runs on this machine hit transient flakiness from unrelated runner.test.ts browser-context contention under high system load — every flaky file passes cleanly alone)
  • npm run typecheck — clean
  • New tests cover: disconnected-alias listing, the true-empty case (unchanged), the new prompt firing/persisting on yes, omitting the field on no/default, never prompting when the flag is already set, never prompting for cloak/slab

🤖 Generated with Claude Code

Plain-text `profile list` returned early on zero connected runtimes, hiding aliases that already existed in config.
`webcmd setup` only honored --sync-to-chrome as a flag, so interactive chrome selection never asked whether to export profiles into native Chrome.
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🟠 Maintainer review suggested — low confidence

The automated review could not reach a fully supported conclusion.

Limitations

  • The automated review returned an invalid structured result.

This review is advisory and does not block merging.

@ankitranjan7
ankitranjan7 merged commit 1b05e6a into main Sep 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant