Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
josjeon
marked this pull request as ready for review
October 26, 2026 21:33
wrisa
approved these changes
Oct 26, 2026
josjeon
enabled auto-merge (squash)
October 27, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
422 VALIDATION_ERRORwith guidance to supplytarget_typeandtarget_id.Scope
control_idremains an additional filter within an authorized target.Risk and Rollout
Testing
make checkstages across tests, lint, and typechecking. Resumedcontrib-test lint typecheckwith public PyPI after the configured registry returned 401; all remaining stages passed. Server: 1,040 passed. SDK: 754 passed, 2 skipped.400 -> 502; patched request422without an upstream call; complete targets return 200 with an empty list in both versions.Checklist
server/README.md.Incident regression coverage
The HTTP regression matrix uses environment-driven startup configuration for both deployment URL shapes (HTTP and HTTPS), rather than manually enabling the provider flag.
control_idonly (33, 37, 80)target_typeor onlytarget_id, with or withoutcontrol_idcontrol_id, but no targetcontrol_idfilterThe matrix covers 16 incomplete query shapes in both URL configurations plus valid filtering, pagination, and empty-list cases. Existing tests also cover upstream 401/403/404 denials, mismatched grants, by-ID binding reads, generic upstreams, registration/runtime operations, and unexpected upstream failures.
The incident's missing-target-context rejection is covered. Original query parameters for the later incident were not recovered, so its exact external request is not claimed as a replay. Non-empty malformed target syntax remains outside this presence-validation fix.