ateomnet: drop the unused PodIPv4 helper - #1635
Open
haiyanmeng wants to merge 1 commit into
Open
Conversation
Nothing calls it, and its comment documents a design that is gone: it says the pod IP stays available for "the temporary inbound DNAT rule", but no DNAT rule exists anywhere in the tree. Inbound traffic reaches the actor through the atunnel ingress server, which proxies to the actor veth address, and InstallActorNftablesRules installs only REDIRECT, masquerade, and forward-accept. Leaving it in place costs a reader the time to work out which of the two descriptions of actor ingress is the current one.
haiyanmeng
added
kind/cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing calls it, and its comment documents a design that is gone: it says the pod IP stays available for "the temporary inbound DNAT rule", but no DNAT rule exists anywhere in the tree. Inbound traffic reaches the actor through the atunnel ingress server, which proxies to the actor veth address, and InstallActorNftablesRules installs only REDIRECT, masquerade, and forward-accept.
Leaving it in place costs a reader the time to work out which of the two descriptions of actor ingress is the current one.