Store the in-progress snapshot as a URI instead of a name - #1609
Open
Luiz Oliveira (laoj2) wants to merge 1 commit into
Open
Store the in-progress snapshot as a URI instead of a name#1609Luiz Oliveira (laoj2) wants to merge 1 commit into
Luiz Oliveira (laoj2) wants to merge 1 commit into
Conversation
Luiz Oliveira (laoj2)
requested a review
from Julian Gutierrez Oschmann (juli4n)
September 11, 2026 14:59
To build a snapshot URI, we need the external storage location (which is stored in the actor template), actor atespace and UID (which are stored in the actor resource). If an actorTemplate was deleted, we'd leak the in-progress snapshot, because the storage information was gone. Fixes agent-substrate#1608
Luiz Oliveira (laoj2)
force-pushed
the
in-progress-snapshot
branch
from
September 11, 2026 15:00
86dd4a0 to
e54e013
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To build a snapshot URI, we need the external storage location (which is stored in the actor template), actor atespace and UID (which are stored in the actor resource). If an actorTemplate was deleted, we'd leak the in-progress snapshot, because the storage information was gone.
Fixes #1608