benchmarking: expose raw atelet and ate metrics via Prometheus export… - #1601
Open
Nishanth Kotla (Nishanth29) wants to merge 1 commit into
Open
benchmarking: expose raw atelet and ate metrics via Prometheus export…#1601Nishanth Kotla (Nishanth29) wants to merge 1 commit into
Nishanth Kotla (Nishanth29) wants to merge 1 commit into
Conversation
…er in telemetry-meter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1589
What this PR does
This PR routes incoming raw OTLP metrics from
ateletandateapito the Prometheus pull exporter on port 8889 inbenchmarking/telemetry/meter.yaml.Problem
Currently,
telemetry-meteronly routes aggregated count metrics (substrate_spansandsubstrate_datapoints) to the Prometheus exporter on port 8889. Raw OTLP metrics (including snapshot sizes, restore durations, and worker pool states) are only forwarded upstream to managed cloud collectors.In local or standalone benchmarking environments where cloud monitoring backends are not configured, in-cluster Prometheus cannot scrape these raw histograms and gauges.
Proposed Changes
In
benchmarking/telemetry/meter.yaml:metrics/rawpipeline underservice.pipelinesrouting incomingotlpmetrics through thememory_limiterprocessor to theprometheusexporter on port 8889.How this was tested
Deployed on a benchmark cluster and ran the
gluttonuser workload.Verified that
telemetry-meter:8889exposesatelet_snapshot_size_bytesandate_workerpool_workers.Verified that in-cluster Prometheus scrapes these metrics via the default pod annotations without error.
Tests pass
Appropriate changes to documentation are included in the PR