license and boilerplate - #61
Conversation
Jaana Dogan (rakyll)
left a comment
Jaana Dogan (rakyll)
left a comment
There was a problem hiding this comment.
LGTM after the comments.
| @@ -0,0 +1,141 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
There more established pattern to verify headers is adding addlicense and comparing the output, see https://github.com/google/ax/blob/main/.github/workflows/go.yml#L40 as an example.
We don't have to maintain a bespoke verifier.
There was a problem hiding this comment.
thats how we do for all kube projects.
There was a problem hiding this comment.
let me remove that and we can add it later.
There was a problem hiding this comment.
actually - thats what we also use in the main repo. lets use that for uniformity?
| - name: Test | ||
| run: make test | ||
|
|
||
| - name: Build |
There was a problem hiding this comment.
This is redundant, right? make test captures make build.
b186eaa to
f18c6df
Compare
|
Is this mergable? |
|
AFAIU it is. I havent followed the internal thread though. |
|
This LGTM. We can follow up if there is anything we missed. |
2 participants
cc: thokin as well