Skip to content

Refonte Trésorie > Facture - Ajout / Edition#2185

Open
vgreb wants to merge 1 commit intoafup:masterfrom
vgreb:refacto/accounting-invoice-edit
Open

Refonte Trésorie > Facture - Ajout / Edition#2185
vgreb wants to merge 1 commit intoafup:masterfrom
vgreb:refacto/accounting-invoice-edit

Conversation

@vgreb
Copy link
Copy Markdown
Collaborator

@vgreb vgreb commented Apr 8, 2026

resolves #2007

@vgreb vgreb force-pushed the refacto/accounting-invoice-edit branch 4 times, most recently from d755723 to d8a8313 Compare April 9, 2026 14:30
@vgreb vgreb marked this pull request as ready for review April 9, 2026 14:30
@vgreb
Copy link
Copy Markdown
Collaborator Author

vgreb commented Apr 9, 2026

@Mopolo @stakovicz @agallou En partant du principe qu'une facture est générée à partir d'un devis, je n'autorise pas l'ajout ou la suppression d'une ligne de détails.

Est-ce que ça raccord avec les process de la trésorerie ?

@vgreb vgreb force-pushed the refacto/accounting-invoice-edit branch from d8a8313 to bc7e3af Compare April 10, 2026 22:08
@stakovicz
Copy link
Copy Markdown
Contributor

stakovicz commented Apr 11, 2026

@Mopolo @stakovicz @agallou En partant du principe qu'une facture est générée à partir d'un devis, je n'autorise pas l'ajout ou la suppression d'une ligne de détails.

Est-ce que ça raccord avec les process de la trésorerie ?

Je pense que oui. Ça pourra faire l'objet d'une évolution plus tard sinon.

stakovicz
stakovicz reviewed Apr 11, 2026
View reviewed changes
Comment thread app/config/routing/admin_accounting.yml
Comment thread sources/AppBundle/Accounting/Form/InvoiceType.php
Mopolo
Mopolo reviewed Apr 21, 2026
View reviewed changes
Comment thread tests/behat/features/Admin/Tresorerie/DevisFactures.feature Outdated
Comment thread tests/behat/bootstrap/PdfContext.php
Comment thread sources/AppBundle/Controller/Admin/Accounting/Invoice/EditInvoiceAction.php Outdated
@vgreb vgreb force-pushed the refacto/accounting-invoice-edit branch from 77c471b to 4aeb989 Compare April 23, 2026 20:18
@vgreb vgreb self-assigned this Apr 23, 2026
Mopolo
Mopolo reviewed Apr 23, 2026
View reviewed changes
Comment thread sources/AppBundle/Controller/Admin/Accounting/Invoice/EditInvoiceAction.php Outdated
@vgreb vgreb force-pushed the refacto/accounting-invoice-edit branch 2 times, most recently from 6f50df7 to a31e729 Compare April 23, 2026 20:58
Mopolo
Mopolo reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Mopolo Mopolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certains champs sont non-nullables en base et optionnels dans le formulaire. Du coup quand on les édite à vide ça plante :

Expected argument of type "string", "null" given at property path "service".

Les champs que j'ai eu en erreur : service, phone, refClt1, refClt2, refClt3, observation

@vgreb vgreb force-pushed the refacto/accounting-invoice-edit branch from a31e729 to 4837d28 Compare April 24, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mopolo Mopolo Mopolo left review comments

@stakovicz stakovicz stakovicz left review comments

@agallou agallou Awaiting requested review from agallou agallou is a code owner

Assignees

@vgreb vgreb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refonte - Trésorerie > Facture - Modification

3 participants

@vgreb @stakovicz @Mopolo